On Mon, Aug 20, 2018 at 8:38 PM Stefan Beller <sbeller@xxxxxxxxxx> wrote: > > On Mon, Aug 20, 2018 at 6:18 AM Matthew DeVore <matvore@xxxxxxxxxx> wrote: > > > > There were many instances in this file where it seemed like BUG would be > > better, so I created a new commit before this one to switch them over. The > > interdiff is below. > > > > BTW, why are there so many instances of "die" without "_"? I expect all > > errors that may be caused by a user to be localized. > > Well, there is the porcelain layer to be consumed by a human user > and the plumbing that is good for scripts. And in scripts you might want > to grep for certain errors and react to that, so a non-localized error > message makes the script possible to run in any localisation. I probably have a different view about this, but strings (as English sentences) are for human only and should be translated. For machines there should be well defined format (that just might look like English), not totally free text. In some case, this format can be as simple as the "error/warning/fatal" prefix, which is left untranslated, but the rest should be. There is no guarantee that these die() messages will not change in the future, even left untranslated. -- Duy
