On Mon, Aug 20, 2018 at 5:27 PM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > > Jonathan Nieder wrote: > > Stefan Beller wrote: > >> Junio C Hamano wrote: > > >>> * "git submodule" did not correctly adjust core.worktree setting that > >>> indicates whether/where a submodule repository has its associated > >>> working tree across various state transitions, which has been > >>> corrected. > >>> (merge 984cd77ddb sb/submodule-core-worktree later to maint). > >> > >> Personally I do not view this as a bug fix but a feature > >> (but then again my thinking might be tainted of too much > >> submodule work) hence I would not merge it down. > > > > Can you elaborate? > > ... ah, I figured it out. You are saying "would not merge it down to > maint". In that case, I agree, since this this is not a recent bug > (it's existed since before v1.7.10-rc1~14^2~2, 2012-03-02). Yeah; the behavior was the gold standard for submodules ever since, so I am wary of changing it under the guise of fixing a bug. The core.worktree setting doesn't harm the user by default; you need to craft a very specific situation to benefit from this feature. Stefan
