On Mon, Aug 20, 2018 at 6:23 AM Phillip Wood <phillip.wood@xxxxxxxxxxxx> wrote: > On 17/08/2018 23:44, Junio C Hamano wrote: > > * pw/rebase-i-author-script-fix (2018-08-07) 2 commits > > - sequencer: fix quoting in write_author_script > > - sequencer: handle errors from read_author_ident() > > > > Undecided. > > Is it the list consensus to favor this "with extra code, read the > > script written by bad writer" approach? > > I think there was agreement between myself and Eric on the last version, > I'm not sure anyone else has expressed an opinion. Phillip's v4 [1] does take backward-compatibility into account, but with minimal extra code, which seems a reasonable compromise between no backward-compatibility and the heavyweight approach of v3. I left a few comments on v4 [1], but none were blockers, and changes based upon those comments can be done later, so I think the series can move forward. [1]: https://public-inbox.org/git/20180807093452.22524-1-phillip.wood@xxxxxxxxxxxx/