Elijah Newren wrote: > Since both functions are using the same data type, they should either both > refer to it as void *, or both use the real type (struct alloc_state *). > Opt for the latter. > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> Not worth rerolling for this, but these usually go in the opposite order to reflect the chronology: Signed-off-by: Elijah Newren <newren@xxxxxxxxx> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> The patch still looks good to me. :)
