Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >>>> +ifndef NO_TCLTK >>>> +MAN1_TXT_WIP += gitk.txt >>>> +MAN1_TXT = $(MAN1_TXT_WIP) >>>> +else >>>> +TCLTK_FILES += git-gui.txt >>>> +TCLTK_FILES += gitk.txt >>>> +TCLTK_FILES += git-citool.txt >>>> +MAN1_TXT = $(filter-out \ >>>> + $(TCLTK_FILES), \ >>>> + $(MAN1_TXT_WIP)) >>>> +endif >> >> I didn't notice it when I read it for the first time, but asymmetry >> between these two looks somewhat strange. If we are adding gitk.txt >> when we are not declining TCLTK based programs, why can we do >> without adding git-gui and git-citool at the same time? If we know >> we must add gitk.txt when we are not declining TCLTK based programs >> to MAN1_TXT_WIP in this section, it must mean that when we do not >> want TCLTK based programs, MAN1_TXT_WIP would not have gitk.txt on >> it, so why do we even need it on TCLTK_FILES list to filter it out? > > The only explicitly listed files are those that don't match the wildcard > git-*.txt. Therefore if we want gitk.txt we need to explicitly list only > it, but if we don't want the TCL programs we also need to list the ones > that match git-*.txt. Which means that gitk.txt does not have to be on TCLTK_FILES list, no?
