On Wed, Aug 15, 2018 at 9:53 AM Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > On Wed, Aug 15, 2018 at 6:48 PM Elijah Newren <newren@xxxxxxxxx> wrote: > > > > On Wed, Aug 15, 2018 at 9:24 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > > > > The patch looks good, but since this touches multiple .c files, I > > think I'd s/branch.c/branch/ in the subject line. > > It is about removing the_repository from branch.c though. As much as I > want to completely erase the_repository, that would take a lot more > work. What is your envisioned end state? 1) IMHO we'd first want to put the_repository in place where needed, 2) then start replacing s/the_repository/a repository/ in / 3) builtin/ is not critical, but we'd want to do that later 4) eventually (in the very long run), we'd change the signature of all commands from cmd_foo(int argc, char argv, char *prefix) to cmd_foo(int argc, char argv, struct repository *repo) you seem to be interested in removing the_repository from branch.c, but not as much from bultin/ for now, which is roughly step 2 in that plan?
