On Mon, Aug 13, 2018 at 11:45:06AM -0700, Jonathan Tan wrote:
> > [1/7]: for_each_*_object: store flag definitions in a single location
> > [2/7]: for_each_*_object: take flag arguments as enum
> > [3/7]: for_each_*_object: give more comprehensive docstrings
> > [4/7]: for_each_packed_object: support iterating in pack-order
> > [5/7]: t1006: test cat-file --batch-all-objects with duplicates
> > [6/7]: cat-file: rename batch_{loose,packed}_object callbacks
> > [7/7]: cat-file: support "unordered" output for --batch-all-objects
>
> Thanks for laying all the patches out so cleanly! All of them are:
> Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
>
> Normally I would re-explain the patches to demonstrate that I understand
> them, but in this case, I think they are simple enough - patches 1, 2,
> 3, and 6 are refactorings that I agree with, patch 5 just makes a test
> more comprehensive, and patches 4 and 7 do what their commit messages
> say.
>
> Stefan brought up the concern that cache.h is increasing in size, but I
> agree with the patch as written that it's probably best that we
> centralize all the flags somewhere, and we can deal with the location in
> a future patch.
Thanks for the review. Here are a few patches on top to deal with the
cache.h thing, as well as some optimizations that came out of discussing
oidset in another thread (I left out for now the "big" optimization of
moving oidset to a different data structure; that's complicated enough
to be dealt with on its own, I think).
The first patch here could arguably be squashed into the final patch of
the original series, but I'm OK with it either way.
[1/4]: cat-file: use oidset check-and-insert
[2/4]: cat-file: split batch "buf" into two variables
[3/4]: cat-file: use a single strbuf for all output
[4/4]: for_each_*_object: move declarations to object-store.h
builtin/cat-file.c | 43 +++++++++++---------
builtin/prune-packed.c | 1 +
cache.h | 75 -----------------------------------
object-store.h | 90 ++++++++++++++++++++++++++++++++++++++++++
packfile.h | 20 ----------
5 files changed, 116 insertions(+), 113 deletions(-)
-Peff
