On Mon, Aug 13, 2018 at 5:26 AM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > Hi, > > > On Fri, 10 Aug 2018, Stefan Beller wrote: > > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > > Well, my rationale for having the explicit `reverse` parameter is: this > code is complex enough, introducing some magic "this and that implies > this" makes it much harder to understand. > > So I am not at all sure that this is a good thing. Yeah I am unsure, too. On the other hand the higher level functions look so much nicer a the complexity is shoved downwards, such that each function is solving problems in their own domain. I'll think of an alternative.
