René Scharfe <l.s.r@xxxxxx> writes: > @@ -182,19 +181,10 @@ static int fsck_msg_type(enum fsck_msg_id msg_id, > static void init_skiplist(struct fsck_options *options, const char > *path) > { > - static struct oid_array skiplist = OID_ARRAY_INIT; > - int sorted; > FILE *fp; > struct strbuf sb = STRBUF_INIT; > struct object_id oid; > - if (options->skiplist) > - sorted = options->skiplist->sorted; > - else { That SP before '-' on the removed line is the most curious aspect of this patch; I do not recall the last time I saw a corrupt patch from you---changed where you read/write your mails recently? > @@ -317,9 +300,7 @@ static void append_msg_id(struct strbuf *sb, const char *msg_id) > static int object_on_skiplist(struct fsck_options *opts, struct > object *obj) > { > - if (opts && opts->skiplist && obj) > - return oid_array_lookup(opts->skiplist, &obj->oid) >= 0; > - return 0; > + return opts && obj && oidset_contains(&opts->skiplist, &obj->oid); OK ;-)