> > + cfg_file = xstrfmt("%s/config", subrepo.gitdir); > > As I mentioned here: > https://public-inbox.org/git/20180807230637.247200-1-bmwill@xxxxxxxxxx/T/#t > > This lines should probably be more like: > > cfg_file = repo_git_path(&subrepo, "config"); > Why? You did not mention the benefits for writing it this way here or on the reference. Care to elaborate?