On Thu, Aug 9, 2018 at 2:44 PM Jeff King <peff@xxxxxxxx> wrote: > > The error message isn't quite as good, but does the user really need > > all the names of the file? If so, we gave them enough information to > > figure it out, and this is a really unusual case anyway, right? > > Besides, now we're back to linear performance.... > > Well, it's still quadratic when they run O(n) iterations of "git > ls-files -s | grep $colliding_oid". You've just pushed the second linear > search onto the user. ;) Wouldn't that be their own fault for not running git ls-files -s | grep -e $colliding_oid_1 ... -e $colliding_oid_n | sort -k 2 ? ;-)
