On Thu, Aug 9, 2018 at 5:55 PM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > The following changes have been made since the previous iteration: > > * suggested by Duy: move the code computing the write order for a > layer to a new separate function called compute_layer_order() in > builtin/pack-objects.c in new patch 3/8 > > I think that indeed this makes the following patch (4/8) shorter and > easier to understand as well as the overall result nicer. > > * suggested by Duy and Peff: rework the way the 'tree_depth' field is > moved from 'struct object_entry' to 'struct packing_data' in > pack-object.h in patch 7/8 > > * suggested by Duy and Peff: move field 'layer' from > 'struct object_entry' to 'struct packing_data' in pack-object.h in > new patch 8/8 I forgot to tell about the following change that is also part of the v3: * suggested by Junio and Peff: increase the 'regmatch_t matches[]' array from 8 to 16, advertise 14 group captures max, and add a warning if the final element gets filled in in delta-islands.c in patch 2/8
