On Tue, Aug 7, 2018 at 5:35 AM Phillip Wood <phillip.wood@xxxxxxxxxxxx> wrote: > Check for a NULL return value from read_author_ident() that indicates > an error. Previously the NULL author was passed to commit_tree() which > would then fallback to using the default author when creating the new > commit. This changed the date and potentially the author of the commit > which corrupted the author data compared to its expected value. > > Helped-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > Signed-off-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > --- > changes since v3: > - Implemented the simpler scheme suggested by Eric This iteration is much nicer, much simpler, and much easier to review. Thanks.