Hi Elia
On 7 August 2018 at 15:21, Elia Pinto <gitter.spiros@xxxxxxxxx> wrote:
> Add the '--quiet' option to git worktree add,
> as for the other git commands.
>
> Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
> ---
> Documentation/git-worktree.txt | 4 +++-
> builtin/worktree.c | 11 +++++++++--
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
> index 9c26be40f..508cde55c 100644
> --- a/Documentation/git-worktree.txt
> +++ b/Documentation/git-worktree.txt
> @@ -115,7 +115,9 @@ Unlock a working tree, allowing it to be pruned, moved or deleted.
>
> OPTIONS
> -------
> -
Grepping through Documentation/, it is clear that we sometimes have a
blank line here, sometimes not. I'm not sure what to make of that.
> +-q::
> +--quiet::
> + With 'add', suppress feedback messages.
> -f::
But I do think that for consistency, we'd prefer a blank line before `-f::`.
Both the commit message and this documentation makes me wonder if this
focuses on "add" because it's the only subcommand where `--quiet` makes
sense, conceptually, or because this is where you happen to need it
personally, or due to some other $reason. Could you say something more
about this?
I'm not a worktree power-user, so please forgive my ignorance...
> @@ -315,6 +316,9 @@ static int add_worktree(const char *path, const char *refname,
> cp.argv = NULL;
> argv_array_clear(&cp.args);
> argv_array_pushl(&cp.args, "reset", "--hard", NULL);
> + if (opts->quiet)
> + argv_array_push(&cp.args, "--quiet");
> + printf("%s\n","soo qia");
This last line looks like debug cruft.
> @@ -437,6 +441,7 @@ static int add(int ac, const char **av, const char *prefix)
> OPT_BOOL(0, "detach", &opts.detach, N_("detach HEAD at named commit")),
> OPT_BOOL(0, "checkout", &opts.checkout, N_("populate the new working tree")),
> OPT_BOOL(0, "lock", &opts.keep_locked, N_("keep the new working tree locked")),
> + OPT__QUIET(&opts.quiet, N_("suppress progress reporting")),
This matches other users. Good.
I did some simple testing and this appears to be quite quiet, modulo
the "soo qia" that I already mentioned. Could you add a test to
demonstrate the quietness and to keep it from regressing? Something like
`git worktree add ../foo >out && test_must_be_empty out" in e.g.,
t2025-worktree-add.sh might do the trick (capture stderr as well?).
Hope this helps
Martin
