On Thu, Aug 02, 2018 at 03:46:08PM -0400, Eric Sunshine wrote: > On Thu, Aug 2, 2018 at 2:02 PM Jeff King <peff@xxxxxxxx> wrote: > > On Thu, Aug 02, 2018 at 01:55:22PM +0200, SZEDER Gábor wrote: > > > This approach uses $(eval), which we haven't used in any of our > > > Makefiles yet. I wonder whether it's portable enough. And it's > > > ugly and complicated. > > > > I looked into this a long time ago for another set of Makefile patches I > > was considering. $(eval) was added to GNU make in 3.80, released in > > 2002. Which is probably fine by now. > > For the record, MacOS developer tools are stuck at GNU make 3.81 (from 2006). Thanks, that's interesting to know. Fortunately from my past research that means that it should have both $(eval) and $(call). If we follow my suggestions here, we don't need to care for now, but I won't be surprised if it comes up again at some point. -Peff
