On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite <ao2@xxxxxx> wrote: > > The is_empty_file() function can be generally useful, move it to dir.c > and make it public. > > Signed-off-by: Antonio Ospite <ao2@xxxxxx> Makes sense, Thanks, Stefan > +++ b/dir.c > @@ -2412,6 +2412,22 @@ int is_empty_dir(const char *path) > return ret; > } > > +/** > + * Returns 1 if the file is empty or does not exist, 0 otherwise. > + */ Please move the comment to the header instead. /* possibly as a oneliner ? */