On Thu, Aug 2, 2018 at 12:24 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Wed, Aug 1, 2018 at 2:17 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes: > > > Sorry for being dense, but do you want me to send an updated patch or > > > not based on your and Eric's comments or not? > > > > It would help to see the comments responded with either "such a > > change is not needed for such and such reasons", "it may make sense > > but let's leave it to a follow-up patch later," etc., or with a > > "here is an updated patch, taking all the comments to the previous > > version into account---note that I rejected that particular comment > > because of such and such reasons". > > Right. The way to know whether or not an updated patch is warranted is > to respond to review comments, saying that you agree or disagree with > various points raised (and why), and by answering the (genuine) > questions raised during review. The outcome of the dialogue with > reviewers will make it clear if an updated patch is necessary. (It's > also a courtesy to respond to review comments since reviewing is > time-consuming business and it's good to let reviewers know that the > time spent reviewing was not in vain.) Sure. My doubt is that it's hard to tell what the state of my patch is at any given time. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
