Chen Bin <chenbin.sh@xxxxxxxxx> writes: > The `p4-pre-submit` hook is executed before git-p4 submits code. > If the hook exits with non-zero value, submit process won't start. > > Signed-off-by: Chen Bin <chenbin.sh@xxxxxxxxx> > --- I see that the only difference between this and what has been queued on 'pu', i.e. https://github.com/gitster/git/commit/fb78b040c5dc5b80a093d028d13f8cd32ade17cd is that this is missing the update in https://public-inbox.org/git/xmqq1sbkfneo.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ and also Luke's "Reviewed-by:". I recall that you had trouble getting "git p4" in the test (not "git-p4") working for some reason. Has that been resolved (iow have you figured out why it was failing?) Thanks.
