Jeff King <peff@xxxxxxxx> writes: > +... > + } else if (cmp > 0) { > /* path2 does not appear in one */ > + score += score_missing(two.entry.mode, two.entry.path); > + update_tree_entry(&two); > + continue; > + } if (oidcmp(one.entry.oid, two.entry.oid)) { As the earlier ones do the "continue at the end of the block", this does not affect the correctness, but I think you either meant "else if" or a fresh "if/else" that is disconnected from the previous if/else if/... chain. > /* they are different */ > ... > + score += score_differs(one.entry.mode, two.entry.mode, > + one.entry.path); > + } else {