Re: [PATCH 1/1] Add the `p4-pre-submit` hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/1] Add the `p4-pre-submit` hook
From: Luke Diamand <luke@xxxxxxxxxxx>
Date: Tue, 31 Jul 2018 15:40:05 +0200
Cc: Chen Bin <chenbin.sh@xxxxxxxxx>, Git Users <git@xxxxxxxxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>
In-reply-to: <20180731084638.18793-1-szeder.dev@gmail.com>
References: <xmqq36w6rlh7.fsf@gitster-ct.c.googlers.com> <20180727112222.19061-1-chenbin.sh@gmail.com> <20180731084638.18793-1-szeder.dev@gmail.com>

I think there is an error in the test harness.

On 31 July 2018 at 10:46, SZEDER Gábor <szeder.dev@xxxxxxxxx> wrote:
>> +             test_must_fail git-p4 submit --dry-run >errs 2>&1 &&>
>> +             ! grep "Would apply" err

It writes to the file "errs" but then looks for the message in "err".

Luke

Follow-Ups:
- Re: [PATCH 1/1] Add the `p4-pre-submit` hook
  - From: Junio C Hamano

References:
- Re: [PATCH 1/1] add hook pre-p4-submit
  - From: Junio C Hamano
- [PATCH 1/1] Add the `p4-pre-submit` hook
  - From: Chen Bin
- Re: [PATCH 1/1] Add the `p4-pre-submit` hook
  - From: SZEDER Gábor

Prev by Date: [PATCH v2 10/10] fetch: stop clobbering existing tags without --force
Next by Date: Re: Is detecting endianness at compile-time unworkable?
Previous by thread: Re: [PATCH 1/1] Add the `p4-pre-submit` hook
Next by thread: Re: [PATCH 1/1] Add the `p4-pre-submit` hook
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux