Hi Jonathan, On Mon, 23 Jul 2018, Jonathan Nieder wrote: > Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > Sadly, we do not get all of the definitions via ALL_CFLAGS. Some defines > > are passed to GCC *only* when compiling specific files, such as git.o. > > > > Let's just hard-code them into the script for the time being. > > Could we move these to ALL_CFLAGS? Is there any downside other than > increased rebuilds when options change? I assumed that it gives us a bit more liberty at using names for constants that might otherwise be too general. I did not even consider the rebuild time, but that's a good point. The idea to move those definitions to ALL_CFLAGS sounds good to me, yet I am loathe to introduce this into a patch series that is not about far-reaching design decisions at all, but merely about making a decent tool available to the finger tips of all Git contributors. Read: I think this would make for a pretty good micro-project, maybe in next year's GSoC (assuming that it happens and that we're accepted again). Ciao, Dscho
