On 29/07/18 04:13, Eric Sunshine wrote:
> On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones
> <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
>> receive-pack", 2018-07-27) adds a test which uses the non-portable
>> export construct. Replace it with "FOO=bar && export FOO" instead.
>>
>> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> Could you please put this on top of the 'mk/http-backend-content-length'
>> branch. This test tickles the new "export FOO=bar" check, so the test
>> suite does not run otherwise.
>
> The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect
> 'export FOO=bar', 2013-07-08), so is not exactly new.
>
> Perhaps you were thinking of [1] a0a630192d
Heh, yes you are obviously correct. Although 'thinking' might
be being too generous! ;-)
[I can't even claim that it was late ... midnight is actually
quite early for me!]
> (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13),
> when you wrote this, though it is not related to "export FOO=bar"
> detection.
>
> The patch itself looks fine, by the way.
>
> [1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@xxxxxxxxxxxxxx/
>
Thanks!
ATB,
Ramsay Jones
