t5515 in general

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It looks to me like t5515 enshrines a number of infelicities in the 
current fetch code. For example, if you have a branch configuration which 
specifies a remote that's configured through a branches/* file, and you 
have a merge setting for the branch, it's ignored, and we test that it's 
ignored with a whole bunch of tests. I think that the behavior here should 
either be unspecified, or we should make it more generally consistant 
(i.e., if you specify any "merge" items, this overrides the default of 
using the first refspec, even if the first refspec is implicit in the fact 
that you're using a branches/* file, which automatically only has the 
configured refspec refs/heads/master:). Or leave it unspecified and 
untested, since neither option is actually useful.

This makes me think that a lot of t5515 was done by putting together a 
bunch of configurations and automatically making tests for them without 
checking whether the current behaviour is actually something we want, or 
whether the configuration even could do anything sensible in the first 
place. So it might be worth going through that set and eliminating 
anything not actually predicted by the documentation.

	-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux