On Tue, Jul 24, 2018 at 09:19:27AM -0700, Junio C Hamano wrote: > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > From: Jeff King <peff@xxxxxxxx> > > > > As get_delta_base() will be used outside 'packfile.c' in > > a following commit, let's make it non static and let's > > declare it in 'packfile.h'. > > As a public function in *.h, don't we want a bit of comment there to > help those who want to use it from outside packfile.c? Arguably it may want a better name, too. -Peff