Hi Chris, On Sun, 22 Jul 2018, Christian Couder wrote: > This patch series is upstreaming work made by GitHub and available in: > > https://github.com/peff/git/commits/jk/delta-islands > > The patch in the above branch has been split into 5 patches with their > own new commit message, but no other change has been made. > > I kept Peff as the author and took the liberty to add his > Signed-off-by to all the patches. > > The patches look good to me except perhaps that "pack.islandCore" is > not documented. Maybe something could be added in > Documentation/technical/ too, or maybe improving commit messages could > be enough. > > Anyway I wanted to send this nearly "as is" first to get early > feedback about what should be done. > > This patch series is also available on GitHub in: > > https://github.com/chriscool/git/commits/delta-islands It might make sense to explain *somewhere* in the cover letter what the patches are all about, i.e. what problem they are supposed to solve. I did not see any indication here. Ciao, Dscho > > Jeff King (5): > packfile: make get_delta_base() non static > Add delta-islands.{c,h} > pack-objects: add delta-islands support > repack: add delta-islands support > t: add t9930-delta-islands.sh > > Documentation/config.txt | 8 + > Documentation/git-pack-objects.txt | 88 ++++++ > Documentation/git-repack.txt | 5 + > Makefile | 1 + > builtin/pack-objects.c | 130 +++++--- > builtin/repack.c | 9 + > delta-islands.c | 490 +++++++++++++++++++++++++++++ > delta-islands.h | 11 + > pack-objects.h | 4 + > packfile.c | 10 +- > packfile.h | 3 + > t/t9930-delta-islands.sh | 143 +++++++++ > 12 files changed, 856 insertions(+), 46 deletions(-) > create mode 100644 delta-islands.c > create mode 100644 delta-islands.h > create mode 100755 t/t9930-delta-islands.sh > > -- > 2.18.0.237.gffdb1dbdaa > >
