On 24.07.18 20:22, Junio C Hamano wrote: > Beat Bolli <dev+git@xxxxxxxxx> writes: > >> Hi Jeff >> >> On 24.07.18 17:30, git@xxxxxxxxxxxxxxxxx wrote: >>> From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> >>> >>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added >>> to builtin/config.c to define a new function and a forward declaration >>> for an array of unknown size. This causes a compile error under MSVC. >>> >>> Reorder the code to forward declare the function instead of the array. >> >> This was already fixed (differently) in >> <20180705183445.30901-1-dev+git@xxxxxxxxx>. > > Thanks for saving me from having to dig the list archive myself. > Yes, it is already applied to the tip of the topic that originally > caused the breakage. > Just a general question: Is it OK to refer to patches on pu with the Message-ID, or would you prefer the commit hash? The hash changes whenever you recreate pu, doesn't it? Beat
