On Tue, Jun 19, 2018 at 5:21 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 6/19/2018 10:51 AM, Duy Nguyen wrote: > > Do we run 'make coccicheck' > > automatically somewhere? If true, I need to move this script elsewhere > > because it's meant to run manually. You run it when you intend to do > > more manual fixups afterwards. For builtin/, I think I'll wait until > > 'struct repository *' conversion is complete then maybe fix them one > > by one. > > I don't think it is part of the CI runs, but some community members run > this themselves on 'next' and 'master'. Travis CI does run 'make coccicheck' already, that's the "StaticAnalysis" build job. Alas, it's not particularly useful as it is, because Coccinelle's and in turn 'make coccicheck's exit code only indicates that Coccinelle managed to finish its analysis without any errors (e.g. no unknown --options, no missing files, no syntax errors in the semantic patches, etc.), but it doesn't indicate whether it found any undesired code patterns to transform or not. I have been sitting on two patches implementing two different approaches to improve this situation for several months now (sorry :) I think I'll just pick the shorter-simpler of the two, and submit it shortly.
