On Mon, Jul 2, 2018 at 9:49 PM Jameson Miller <jamill@xxxxxxxxxxxxx> wrote: > +struct cache_entry *make_transient_cache_entry(unsigned int mode, const struct object_id *oid, > + const char *path, int stage) > +{ > + struct cache_entry *ce; > + int len; > + > + if (!verify_path(path, mode)) { > + error("Invalid path '%s'", path); Please wrap all new user-visible strings in _(). > + return NULL; > + } -- Duy