On Fri, Jul 20, 2018 at 11:58:10AM -0700, Junio C Hamano wrote: > > Note that this needs to be applied on top of 022d2ac1f3 (blame: prefer > > xsnprintf to strcpy for colors, 2018-07-13) or it will complain loudly. :) > > > > [1/2]: introduce "banned function" list > > [2/2]: banned.h: mark strncpy as banned > > Hmph, there is no use of any banned function in hex.c, but when > this topic is merged to 'pu', I seem to get this: Interesting. Builds fine for me even merged to the latest push-out of pu. But... > $ make DEVELOPER=1 hex.o > GIT_VERSION = 2.18.0.758.g18f90b35b8 > CC hex.o > In file included from git-compat-util.h:1250:0, > from cache.h:4, > from hex.c:1: > banned.h:14:0: error: "strncpy" redefined [-Werror] > #define strncpy(x,y,n) BANNED(strncpy) > > In file included from /usr/include/string.h:630:0, > from git-compat-util.h:165, > from cache.h:4, > from hex.c:1: > /usr/include/x86_64-linux-gnu/bits/string2.h:84:0: note: this is the location of the previous definition > # define strncpy(dest, src, n) __builtin_strncpy (dest, src, n) I suspect it has more to do with system/libc differences between our machines, anyway. There was discussion elsewhere in the thread about the need to #undef before redefining. I guess this answers that question. I'll include that in the re-roll, and you can just ignore the v1 patches I sent for now. -Peff
