Hi Eric, On Tue, Jul 17, 2018 at 11:59 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Tue, Jul 17, 2018 at 2:53 PM Stefan Beller <sbeller@xxxxxxxxxx> wrote: > > > A tangent. > > > > > > Because this "-- " is a conventional signature separator, MUAs like > > > Emacs message-mode seems to omit everything below it from the quote > > > while responding, making it cumbersome to comment on the tbdiff. > > > > > > Something to think about if somebody is contemplating on adding more > > > to format-patch's cover letter. > > > > +cc Eric who needs to think about this tangent, then. > > https://public-inbox.org/git/20180530080325.37520-1-sunshine@xxxxxxxxxxxxxx/ > > The "git-format-patch --range-diff" option implemented by that patch > series (and its upcoming re-roll) place the range-diff before the "-- > " signature line, so this isn't a problem. > > I think Junio's tangent was targeted more at humans blindly plopping > the copy/pasted range-diff at the end of the cover letter without > taking the "-- " signature line into account. (Indeed, Gmail hides > everything below the "-- " line by default, as well.) Awesome thanks! (I missed that hint given by Junio) Now that I grow more accustomed to range-diffs, I wonder if we want to have them even *before* the short stat in the cover letter. (I usually scroll over the short stat just to take it as a FYI on what to expect, whereas the range-diff can already be reviewed, hence seems more useful that the stats) Thanks, Stefan
