Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Hi Olga, > > On Fri, 13 Jul 2018, Оля Тележная wrote: > >> 2018-07-09 11:27 GMT+03:00 Оля Тележная <olyatelezhnaya@xxxxxxxxx>: >> > Hello everyone, >> > This is my new attempt to start using oid_object_info_extended() in >> > ref-filter. You could look at previous one [1] [2] but it is not >> > necessary. >> > >> > The goal (still) is to improve performance by avoiding calling expensive >> > functions when we don't need the information they provide >> > or when we could get it by using a cheaper function. >> > >> > This patch is a middle step. In the end, I want to add new atoms >> > ("objectsize:disk" and "deltabase") and reuse ref-filter logic in >> > cat-file command. >> > >> > I also know about problems with memory leaks in ref-filter: that would >> > be my next task that I will work on. Since I did not generate any new >> > leaks in this patch (just use existing ones), I decided to put this >> > part on a review and fix leaks as a separate task. >> >> UPDATES since v1: >> add init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin) >> improve second commit message (thanks to Junio C Hamano) >> add static keyword (thanks to Ramsay Jones) >> >> > >> > Thank you! >> > >> > [1] https://github.com/git/git/pull/493 > > Could you please populate the description of that PR so that SubmitGit > picks it up as cover letter? Thanks for suggesting that. Yes, an updated version of a series, even if it is a small one with just 4 or 5 patches, becomes much easier to read with a well-written cover letter.