On Tue, Jul 17, 2018 at 03:15:31PM -0400, Jeff King wrote: > > - Also trigger `prune_shallow()` when `--unpack-unreachable=<approxidate>` was passed to `git repack`. > > - No need to trigger `prune_shallow()` when `git repack` was called with `-k`. > > I think you might have missed the bigger problem I pointed at, as it was > buried deep within my later reply. Try applying this patch on top, which > tests the opposite case (reachable shallow commits are retained): By the way, I notice that the patches themselves are cc'd to you, but the cover letter isn't. So my reply went only to gitgitgadget, which (AFAIK) has not yet learned to work as a mail-to-comment gateway. So I'm copying this to you directly to make sure you see it, but also because I'm not sure if the gitgitgadget cc behavior is intentional or not. -Peff
