On Tue, Jul 17, 2018 at 2:10 PM Paul-Sebastian Ungureanu <ungureanupaulsebastian@xxxxxxxxx> wrote: > > At the moment, `get_oid()` might call `die()` in some cases. To > prevent that from happening, this patches introduces a new flag > called `GET_OID_GENTLY` and a new function `get_oid_gently()`, > which passes the mentioned flag further to `get_oid_with_context()`. Since get_oid() callers must handle failure when it returns non-zero, I would say "gently" is already implied by get_oid() and we could just convert those die() to error() or warning(). Unless some of those die() are very special that we need to choose which call sites should go "even gentler" where some sites should still die()? -- Duy
