Hi Eric, On Mon, 16 Jul 2018, Eric Sunshine wrote: > On Tue, Jul 3, 2018 at 7:26 AM Thomas Rast via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > These are essentially lifted from https://github.com/trast/tbdiff, with > > light touch-ups to account for the command now being an option of `git > > branch`. > > The "option of `git branch`" mention is outdated. Perhaps just drop > everything after "...touch-ups" (or mention "range-diff" instead). Ah, the line break made my `grep` fail :-( > > Apart from renaming `tbdiff` to `range-diff`, only one test case needed > > to be adjusted: 11 - 'changed message'. > > [...] > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > diff --git a/t/.gitattributes b/t/.gitattributes > > @@ -18,5 +18,6 @@ t[0-9][0-9][0-9][0-9]/* -whitespace > > /t7500/* eol=lf > > +/t7910/* eol=lf > > Does this need to be changed to t3206? Absolutely. > > > /t8005/*.txt eol=lf > > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh > > new file mode 100755 > > index 000000000..2237c7f4a > > --- /dev/null > > +++ b/t/t3206-range-diff.sh Thanks for your thorough review, Dscho
