Re: [PATCH 12/16] test-reach: test reduce_heads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +test_expect_success 'reduce_heads' '
> +       cat >input <<-\EOF &&
> +               X:commit-1-10
> +               X:commit-2-8
> +               X:commit-3-6
> +               X:commit-4-4
> +               X:commit-1-7
> +               X:commit-2-5
> +               X:commit-3-3
> +               X:commit-5-1
> +       EOF
> +       {
> +               printf "reduce_heads(X):\n" &&
> +               git rev-parse commit-5-1 &&
> +               git rev-parse commit-4-4 &&
> +               git rev-parse commit-3-6 &&
> +               git rev-parse commit-2-8 &&
> +               git rev-parse commit-1-10

Please use rev-parse only once.

I am not sure about the usage of { braces } in the test suite,
+cc Eric who sent a test suite linting series recently.
Do we need to em-'brace' the statements that describe the
expected behavior? (Or is it supposed to be easier to read
for the reviewers? I found these very readable so far... but
this question just came up)

Thanks,
Stefan



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux