On Wed, Jun 13, 2007 at 10:38:21PM +0200, Yann Dirson wrote: > > The HEAD in my repository fails the test suite. Do you have any > > additional patches pending (some patches were not applied in order as > > I had to manually fix the conflicts). Anyway, please check my > > repository for any missing patches. > > Oh, I had not noticed you had applied > bd69feaf7c3c94b6e7e216ea8091064af9cdfa97. Sorry, I was not explicit > enough when posing this, only the cover mail included "RFC" in the > subject. As described in that mail, there are problems both with the > original approach (Karl's test failing), and with that new one (that > exisiting test failing). > > Do you have any idea on how we could overcome the problem ? In the > meantime, we could possibly just comment that testcase out (or add > support for continuing the testsuite even with a failure) - the > problem it exhibits is probably less common than the one that was > fixed. Well, the patch I just sent which adds GIT_SKIP_TESTS support allows to see that this patch indeed breaks another test - the testsuite can be forced to skip them [1] for the sake of checking one did not break anything else, but the second test that does not pass is annoying as well, due to a similar problem: When the parent branch is a rewinding one (eg. an stgit stack), then the old version of the patch will be turned to unreachable by pull/rebase, and we probably have even no way of telling stgit that it is indeed expected, since the parent stack is a local one. My own workflow on StGIT is affected by the issue, since my "bugs" stack is forked off my "master" stack (but hopefully an hydra will help me ;). That makes me suspecting the reachability approach is a dead-end, and we should either get back to the approach of recording old-base, or find another solution. Best regards, -- Yann [1] GIT_SKIP_TESTS='t2100.4 t2102.3' make test - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
