On Mon, Jul 16, 2018 at 8:21 AM Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Mon, Jul 16, 2018 at 01:27:52AM +0000, brian m. carlson wrote: > > This is the fourteenth series of patches to switch to using struct > > object_id and the_hash_algo. This series converts several core pieces > > to use struct object_id, including the oid* and hex functions. > > > > All of these patches have been tested with both SHA-1 and a 256-bit > > hash. > > > > Most of these patches are fixes for things that will clearly cause > > segfaults or other very obvious breakage on a Git with a 256-bit hash. > > > > Changes from v1: > > * Drop patch that's been replaced by one from Ben Peart. > > * Update patch handling hash* and oid* functions. > > Along with Derrick, I also read this series and found it to be without > problems. This looks good to me, too. I just had a hickup with the patch replacing number magic ( "(num_parents * 50) + 20") in a strbuf_grow, but I do not see the problem there, it is just a bit of overly large grow estimates. Despite that said, this series is Reviewed-by: Stefan Beller <sbeller@xxxxxxxxxx> Thanks, Stefan
