Re: rev-parse --show-toplevel broken during exec'ed rebase?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: rev-parse --show-toplevel broken during exec'ed rebase?
From: "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 13 Jul 2018 23:05:49 +0000
Cc: Junio C Hamano <gitster@xxxxxxxxx>, Vitali Lovich <vlovich@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Johannes Schindelin <Johannes.Schindelin@xxxxxx>, Jacob Keller <jacob.keller@xxxxxxxxx>
In-reply-to: <20180713201949.GA17670@sigill.intra.peff.net>
Mail-followup-to: "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Vitali Lovich <vlovich@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, Johannes Schindelin <Johannes.Schindelin@xxxxxx>, Jacob Keller <jacob.keller@xxxxxxxxx>
References: <CAF8PYMjub1KK_ZK0hijTNBACSa6SaFyu1dJgrXd5fJU5Hc_dhg@mail.gmail.com> <xmqq7em01ns9.fsf@gitster-ct.c.googlers.com> <20180713184732.GC968742@genre.crustytoothpaste.net> <20180713201949.GA17670@sigill.intra.peff.net>
User-agent: Mutt/1.10.0 (2018-05-17)

On Fri, Jul 13, 2018 at 04:19:49PM -0400, Jeff King wrote:
> Just reading over this thread, I suspect the simplest fix is to pass
> GIT_DIR and GIT_WORK_TREE together, which is almost always the right
> thing to do.

I agree.  I'll write up a patch.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- [PATCH] sequencer: pass absolute GIT_WORK_TREE to exec commands
  - From: brian m. carlson

References:
- rev-parse --show-toplevel broken during exec'ed rebase?
  - From: Vitali Lovich
- Re: rev-parse --show-toplevel broken during exec'ed rebase?
  - From: Junio C Hamano
- Re: rev-parse --show-toplevel broken during exec'ed rebase?
  - From: brian m. carlson
- Re: rev-parse --show-toplevel broken during exec'ed rebase?
  - From: Jeff King

Prev by Date: Re: [PATCH] blame: prefer xsnprintf to strcpy for colors
Next by Date: [PATCH] sequencer: pass absolute GIT_WORK_TREE to exec commands
Previous by thread: Re: rev-parse --show-toplevel broken during exec'ed rebase?
Next by thread: [PATCH] sequencer: pass absolute GIT_WORK_TREE to exec commands
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]