On Thu, Jun 14, 2007 at 02:50:55PM +0200, Pierre Habouzit wrote: > This patch series makes guilt be able to work with a standard posix shell. > > This has been tested with bash, zsh, dash and posh acting as /bin/sh. > > This uses awk and sed a bit more than before, but POSIX awk and sed should be > enough. Though GNU find and GNU /bin/echo from the coreutils needs to be > there. > > Here is the shortlog: > > Pierre Habouzit (7): > Regression test suite needs bash, that's OK. > guilt(1): Obvious bashisms fixed. > guilt(1): simplifications... > guilt(1): reimplement push_patch, using a subshell to avoid locals. > Easy commands, without bashisms. > guilt-status(1): Remove bashisms. > Remove last bashisms from remaining commands. I went though the patches, and it's mostly good (see individual patch replies for details). I noticed an indentation issue or two, but I can fix that up easily, I can take care of the quoting of `basename $0`. The regression suite is little lacking, so I am going to put your updated patches onto a special branch, and test it for a while - fixing up any potential bugs. (I don't want to be even remotely responsible for people's patches turning into empty files :) ) Thanks a lot! Josef "Jeff" Sipek. -- A CRAY is the only computer that runs an endless loop in just 4 hours... - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
