Ben Peart <Ben.Peart@xxxxxxxxxxxxx> writes: >> -----Original Message----- >> From: Junio C Hamano <jch2355@xxxxxxxxx> On Behalf Of Junio C Hamano >> Sent: Thursday, July 12, 2018 3:13 PM >> To: Ben Peart <Ben.Peart@xxxxxxxxxxxxx> >> Cc: git@xxxxxxxxxxxxxxx; sbeller@xxxxxxxxxx; johannes.schindelin@xxxxxx >> Subject: Re: [PATCH v3] handle lower case drive letters on Windows >> >> Ben Peart <Ben.Peart@xxxxxxxxxxxxx> writes: >> >> > On Windows, if a tool calls SetCurrentDirectory with a lower case drive >> > letter, the subsequent call to GetCurrentDirectory will return the same >> > lower case drive letter. Powershell, for example, does not normalize the >> > path. If that happens, test-drop-caches will error out as it does not >> > correctly to handle lower case drive letters. >> > >> > Helped-by: Johannes Schindelin <johannes.schindelin@xxxxxx> >> > Signed-off-by: Ben Peart <Ben.Peart@xxxxxxxxxxxxx> >> > --- >> >> Thanks. Will replace, even though showing the whole Buffer (I am >> guessing it is the equivalent of result from getcwd(3) call) and >> complaining about drive "letter" feels a bit strange ;-) >> > > Thanks. I thought it was strange as well until I realized you only see the > error message if there _isn't_ a valid drive letter so seeing the entire > path makes sense as it will likely be something like "\\server\volume\directory" Yup, that is why I thought Dscho meant to say something like "'%s': path without valid drive prefix" in my response ;-)
