Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Thu, Jul 12, 2018 at 2:35 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Junio C Hamano <gitster@xxxxxxxxx> writes: >> Oops, sent before completing the message. >> >> For that to happen, we need a sign-off ;-) >> >> I guess this one would have been caught with the "sed script on >> subshell" linter that does not execute? > > Yes, this is correctly caught when the prerequisite is met. > >> -- >8 -- >> Subject: t5608: fix broken &&-chain >> >> This is inside a loop that is run inside a subshell, in a test that >> is protected with CLONE_2GB prerequisite, one or more which is quite >> likely reason why it wasn't caught durin the previous clean-up. > > s/durin/during/ > > The exact reason is that the prerequisite was not met (indeed, I > wasn't even aware of that prerequisite), so the commit message can be > more direct: > > This was missed by the previous clean-ups due to an unmet > CLONE_2GB prerequisite. > > Thanks for saving a round-trip. > >> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> There still need a sign-off, so ... ;-)
