Am Tue, 10 Jul 2018 09:47:26 -0700
schrieb Junio C Hamano <gitster@xxxxxxxxx>:
> Henning Schild <henning.schild@xxxxxxxxxxx> writes:
>
> > This commit turns parse_gpg_output into an internal function, the
> > only outside user was migrated in an earlier commit.
>
> It is not too big a deal but as we prefer to see our history speak
> in consistent voice, we would usually phrase the above as if we are
> giving an order to "make it so" to the codebase, e.g.
>
> Turn parse_gpg_output() into a static function, as the only
> outside user was removed in the previous step.
>
> or something like that.
>
> These two steps, as you said earlier, are nice clean-up patches
> whose goodness can be measured independently, regardless of the
> gpgsm support which is the primary focus of this series.
I updated the comment of the second one and send them as a seperate
series. I do not expect them to change since there was -- so far -- no
feedback suggesting that. So i am tempted to promise that ;).
Henning
> Thanks.
>
> >
> > Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx>
> > ---
> > gpg-interface.c | 2 +-
> > gpg-interface.h | 2 --
> > 2 files changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/gpg-interface.c b/gpg-interface.c
> > index 0647bd634..09ddfbc26 100644
> > --- a/gpg-interface.c
> > +++ b/gpg-interface.c
> > @@ -35,7 +35,7 @@ static struct {
> > { 'R', "\n[GNUPG:] REVKEYSIG "},
> > };
> >
> > -void parse_gpg_output(struct signature_check *sigc)
> > +static void parse_gpg_output(struct signature_check *sigc)
> > {
> > const char *buf = sigc->gpg_status;
> > int i;
> > diff --git a/gpg-interface.h b/gpg-interface.h
> > index a5e6517ae..5ecff4aa0 100644
> > --- a/gpg-interface.h
> > +++ b/gpg-interface.h
> > @@ -33,8 +33,6 @@ void signature_check_clear(struct signature_check
> > *sigc); */
> > size_t parse_signature(const char *buf, size_t size);
> >
> > -void parse_gpg_output(struct signature_check *);
> > -
> > /*
> > * Create a detached signature for the contents of "buffer" and
> > append
> > * it after "signature"; "buffer" and "signature" can be the same
