Duy Nguyen <pclouds@xxxxxxxxx> writes: > On Sun, Jul 8, 2018 at 1:16 AM Kim Gybels <kgybels@xxxxxxxxxxxx> wrote: >> Should I post a v3 that goes back to the original fix, but uses >> test_i18ngrep instead of grep? > > Yes please. In my comment I did write we didn't need the repo anymore > (or something along that line) which turns out to be wrong. > >> In addition to not breaking any tests, close_all_packs is already used >> in a similar way in am and fetch just before running "gc --auto". >> >> -Kim Sound good. I recall that "clear repo should treat the_repository special" was discussed when we saw the patch that became 74373b5f ("repository: fix free problem with repo_clear(the_repository)", 2018-05-10), instead of treating only the index portion specially. Perhaps it was a more correct approach after all?