Daniel Harding <dharding@xxxxxxxxxxxxx> writes: > One question about my original patch - there I had replaced a "grep > -v" call with a "git stripspace" call in the 'generate correct todo > list' test. Is relying on "git stripspace" in a test acceptable, or > should external text manipulation tools like grep, sed etc. be > preferred? I think trusting stripspace is OK here. Even though this test is not about stripspace (i.e. trying to catch breakage in stripspace), if we broke it, we'll notice it as a side effect of running this test ;-).
