On Tue, Jul 3, 2018 at 8:30 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Duy Nguyen <pclouds@xxxxxxxxx> writes: > > > A singe patch conversion would look like below. But for that to > > happen, convert.c, rerere, ws.c and read-cache.c have to be converted > > first to not use the_index. > > Yes, that was pretty much what I was driving at. I do not have any > trouble seeing a patch that converts callees that are deep in the > callchain and are meant to serve helpers to make them capable of > working on arbitrary in-core index instance. That's a welcome > change that allows us to reuse them in more context (namely, by > callers that want to work on istate that is not the_index > themselves). Skipping the "intermediate" step like this patch would > force us to focus on converting these lower-layer dependencies. OK I'll drop part one and incorporate the changes in later patches. -- Duy
