Kana Natsuno <dev@xxxxxxxxxxxxxxxxxxxx> writes:
> A later patch changes the built-in PHP pattern. These test cases
> demonstrate aspects of the pattern that we do not want to change.
>
> Signed-off-by: Kana Natsuno <dev@xxxxxxxxxxxxxxxxxxxx>
> ---
> t/t4018/php-class | 4 ++++
> t/t4018/php-function | 4 ++++
> t/t4018/php-method | 7 +++++++
> 3 files changed, 15 insertions(+)
> create mode 100644 t/t4018/php-class
> create mode 100644 t/t4018/php-function
> create mode 100644 t/t4018/php-method
>
> diff --git a/t/t4018/php-class b/t/t4018/php-class
> new file mode 100644
> index 0000000..7785b63
> --- /dev/null
> +++ b/t/t4018/php-class
> @@ -0,0 +1,4 @@
> +class RIGHT
> +{
> + const FOO = 'ChangeMe';
> +}
> diff --git a/t/t4018/php-function b/t/t4018/php-function
> new file mode 100644
> index 0000000..35717c5
> --- /dev/null
> +++ b/t/t4018/php-function
> @@ -0,0 +1,4 @@
> +function RIGHT()
> +{
> + return 'ChangeMe';
> +}
> diff --git a/t/t4018/php-method b/t/t4018/php-method
> new file mode 100644
> index 0000000..03af1a6
> --- /dev/null
> +++ b/t/t4018/php-method
> @@ -0,0 +1,7 @@
> +class Klass
> +{
> + public static function RIGHT()
> + {
> + return 'ChangeMe';
> + }
> +}
I no longer speak PHP, and certainly not the modern variant, but
these examples all look good to me.
Whoever invented the convetion to use RIGHT/ChangeMe in t4018 should
get praised---its brilliance shines in new tests like these ;-)
