Hi Derrick, On Thu, Jun 28, 2018 at 2:40 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > * ds/multi-pack-index (2018-06-25) 24 commits > - midx: clear midx on repack > - packfile: skip loading index if in multi-pack-index > - midx: prevent duplicate packfile loads > - midx: use midx in approximate_object_count > - midx: use existing midx when writing new one > - midx: use midx in abbreviation calculations > - midx: read objects from multi-pack-index > - midx: prepare midxed_git struct > - config: create core.multiPackIndex setting > - midx: write object offsets > - midx: write object id fanout chunk > - midx: write object ids in a chunk > - midx: sort and deduplicate objects from packfiles > - midx: read pack names into array > - multi-pack-index: write pack names in chunk > - multi-pack-index: read packfile list > - packfile: generalize pack directory list > - multi-pack-index: expand test data > - multi-pack-index: load into memory > - midx: write header information to lockfile > - multi-pack-index: add 'write' verb > - multi-pack-index: add builtin > - multi-pack-index: add format details > - multi-pack-index: add design document > > When there are too many packfiles in a repository (which is not > recommended), looking up an object in these would require > consulting many pack .idx files; a new mechanism to have a single > file that consolidates all of these .idx files is introduced. pu fails to build for me (with the standard 'make DEVELOPER=1 ...'), and it appears to come from this series: midx.c:567:15: error: ‘write_midx_pack_lookup’ defined but not used [-Werror=unused-function] static size_t write_midx_pack_lookup(struct hashfile *f, It looks like the use of this function was removed in v2 of your series, but the function itself was left behind? Could you take a look? Thanks, Elijah
