On 6/29/2018 5:47 PM, Stefan Beller wrote:
Hi Derrick,
+static int reachable(struct commit *from, int with_flag, int assign_flag, time_t min_commit_date)
[...]
+ if (commit->date < min_commit_date)
+ continue;
[...]
+int can_all_from_reach_with_flag(struct object_array from,
+ int with_flag, int assign_flag,
+ time_t min_commit_date)
Can you expand on why we introduce the min_commit_date in the commit message?
(It looks like a rebase error as I would have expected a move only,
given the subject)
This is a case where this should have been two steps:
1. Remove dependence on the global 'oldest_have' in upload-pack.c by
creating the min_commit_date parameter.
2. Move the code from upload-pack.c to commit-reach.c.
Thanks,
-Stolee
