Derrick Stolee <dstolee@xxxxxxxxxxxxx> writes: > In anticipation of moving the reachable() method to commit-reach.c, > modify the prototype to be more generic to flags known outside of > upload-pack.c. Also rename 'want' to 'from' to make the statement > more clear outside of the context of haves/wants negotiation. FWIW, I find the order of things done quite sensible. Rename, extend, etc., to prepare before moving and then move, not the other way around. You would want to do the same for some symbols named overly broadly you moved in earlier steps, too. Also, if you will be making this function a global one in a later step, now is the time to give it a good name suitable in the new global context before moving in this preparatory step. If it will be file-scope static in its new home, then reachable() may still be a good enough name. Let's keep reading...
