Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Fri, 29 Jun 2018 14:35:48 -0700
Cc: git <git@xxxxxxxxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Jakub Narębski <jnareb@xxxxxxxxx>
In-reply-to: <20180629161223.229661-2-dstolee@microsoft.com>
References: <20180629161223.229661-1-dstolee@microsoft.com> <20180629161223.229661-2-dstolee@microsoft.com>

Hi Derrick,

> +/* Remember to update object flag allocation in object.h */
> +#define PARENT1         (1u<<16)
> +#define PARENT2         (1u<<17)
> +#define STALE           (1u<<18)
> +#define RESULT          (1u<<19)

Something is up with whitespaces here, apart from that this patch
looks good.

References:
- [RFC PATCH 00/13] Consolidate reachability logic
  - From: Derrick Stolee
- [RFC PATCH 01/13] commit-reach: move walk methods from commit.c
  - From: Derrick Stolee

Prev by Date: Re: [PATCH] xdiff: reduce indent heuristic overhead
Next by Date: Re: [RFC PATCH 03/13] commit-reach: move commit_contains from ref-filter
Previous by thread: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c
Next by thread: Re: [RFC PATCH 01/13] commit-reach: move walk methods from commit.c
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux